From 18824021cb0f6e468bd8c22396cf0adf7a36aaf4 Mon Sep 17 00:00:00 2001
From: Chris Cascioli <chriscascioli@gmail.com>
Date: Thu, 2 Sep 2021 11:49:54 -0400
Subject: [PATCH] Updated input class to return "code analysis" warnings. Added
 initialization to description structs.

---
 Game.cpp  |  4 ++--
 Input.cpp |  4 +++-
 Input.h   | 20 ++++++++++----------
 3 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/Game.cpp b/Game.cpp
index b3c4405..b25dada 100644
--- a/Game.cpp
+++ b/Game.cpp
@@ -180,7 +180,7 @@ void Game::CreateBasicGeometry()
 	// Create the VERTEX BUFFER description -----------------------------------
 	// - The description is created on the stack because we only need
 	//    it to create the buffer.  The description is then useless.
-	D3D11_BUFFER_DESC vbd;
+	D3D11_BUFFER_DESC vbd = {};
 	vbd.Usage = D3D11_USAGE_IMMUTABLE;
 	vbd.ByteWidth = sizeof(Vertex) * 3;       // 3 = number of vertices in the buffer
 	vbd.BindFlags = D3D11_BIND_VERTEX_BUFFER; // Tells DirectX this is a vertex buffer
@@ -202,7 +202,7 @@ void Game::CreateBasicGeometry()
 	// Create the INDEX BUFFER description ------------------------------------
 	// - The description is created on the stack because we only need
 	//    it to create the buffer.  The description is then useless.
-	D3D11_BUFFER_DESC ibd;
+	D3D11_BUFFER_DESC ibd = {};
 	ibd.Usage = D3D11_USAGE_IMMUTABLE;
 	ibd.ByteWidth = sizeof(unsigned int) * 3;	// 3 = number of indices in the buffer
 	ibd.BindFlags = D3D11_BIND_INDEX_BUFFER;	// Tells DirectX this is an index buffer
diff --git a/Input.cpp b/Input.cpp
index ef3d6c0..597c067 100644
--- a/Input.cpp
+++ b/Input.cpp
@@ -98,7 +98,9 @@ void Input::Update()
 	memcpy(prevKbState, kbState, sizeof(unsigned char) * 256);
 
 	// Get the latest keys (from Windows)
-	GetKeyboardState(kbState);
+	// Note the use of (void), which denotes to the compiler
+	// that we're intentionally ignoring the return value
+	(void)GetKeyboardState(kbState);
 
 	// Get the current mouse position then make it relative to the window
 	POINT mousePos = {};
diff --git a/Input.h b/Input.h
index 7914a11..67901ec 100644
--- a/Input.h
+++ b/Input.h
@@ -67,20 +67,20 @@ public:
 
 private:
 	// Arrays for the current and previous key states
-	unsigned char* kbState;
-	unsigned char* prevKbState;
+	unsigned char* kbState {0};
+	unsigned char* prevKbState {0};
 
 	// Mouse position and wheel data
-	int mouseX;
-	int mouseY;
-	int prevMouseX;
-	int prevMouseY;
-	int mouseXDelta;
-	int mouseYDelta;
-	float wheelDelta;
+	int mouseX {0};
+	int mouseY {0};
+	int prevMouseX {0};
+	int prevMouseY {0};
+	int mouseXDelta {0};
+	int mouseYDelta {0};
+	float wheelDelta {0};
 
 	// The window's handle (id) from the OS, so
 	// we can get the cursor's position
-	HWND windowHandle;
+	HWND windowHandle {0};
 };